Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Address review comments from #767#769

Merged
abarth merged 1 commit intoflutter:masterfrom
abarth:drawer_followup
Aug 22, 2015
Merged

Address review comments from #767#769
abarth merged 1 commit intoflutter:masterfrom
abarth:drawer_followup

Conversation

@abarth
Copy link
Contributor

@abarth abarth commented Aug 22, 2015

Mostly formating and removing arguments with default values.

@abarth
Copy link
Contributor Author

abarth commented Aug 22, 2015

@Hixie

@abarth abarth mentioned this pull request Aug 22, 2015
Merged
Hixie
Hixie reviewed Aug 22, 2015
View reviewed changes
examples/fitness/lib/settings.dart Outdated
Copy link
Contributor

@Hixie Hixie Aug 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break between the arguments :-)

@Hixie
Copy link
Contributor

Hixie commented Aug 22, 2015

LGTM

@abarth
Address review comments from flutter#767
1db6f20 
Mostly formating and removing arguments with default values.
abarth added a commit that referenced this pull request Aug 22, 2015
@abarth
Merge pull request #769 from abarth/drawer_followup
a67839d 
Address review comments from #767
@abarth abarth merged commit a67839d into flutter:master Aug 22, 2015
@abarth abarth deleted the drawer_followup branch August 22, 2015 18:26
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 6, 2015
@Hixie
Make RRect useful
ede65b9 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
@Hixie Hixie mentioned this pull request Dec 6, 2015
Merged
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
93070c2 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
f4caccf 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
ab12d86 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
f6c1b5f 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
9b0efaf 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
cf29ec3 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
bf92b6e 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
b697f14 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Dec 7, 2015
@Hixie
Make RRect useful
5bf05d6 
Other changes:
 - Remove the default constructor for RRect and Rect.
 - Add trailing periods to Offset comments.
 - Add Offset.distanceSquared for people who want to compare x^2+y^2
   to r^2 without paying the cost of the sqrt. (Corresponding fix to
   OvalRect coming in a separate flutter patch.)
 - Fix a bug in Rect.lerp().
 - Fix various Rect comments.
 - Remove a "var" in Rect.

Fixes flutter#769.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abarth @Hixie