Add FFI to libraries.yaml.#7811
Conversation
|
Why should this be not included in the next roll (as any temporary patches do)? |
Are the temporary patches automatically included? If so, then this isn't necessary. |
@bkonyi should know. If not then we should, because that's precisely the point of the patches: they exist temporarily until the next roll happens which should include them (that's how we can do breaking API changes and keep 3head green) |
sjindel-google
requested review from
bkonyi
and removed request for
mkustermann
|
I'm not familiar with the patching mechanism, but the @aam might know more about the patches. |
|
Then let's merge this PR. Though you might want to integrate the auto-roller with the 3head patches we have, see tools/patches/flutter-engine/apply.sh |
flutter/engine@d48de7a...3757390 git log d48de7a..3757390 --no-merges --oneline 3757390 Roll src/third_party/dart ecd7a88606..0a7dcf17eb (4 commits) 61d3080 Add FFI to libraries.yaml. (flutter/engine#7811) f5259b8 Roll src/third_party/skia b6f53783337e..186669c4128b (8 commits) (flutter/engine#7816) 816921b Use newer Skia API for PathMeasure (flutter/engine#7809) da56ff9 Roll src/third_party/skia 94a5328e0e4b..b6f53783337e (8 commits) (flutter/engine#7812) 04fbc25 Roll src/third_party/skia 66f09a72995a..94a5328e0e4b (1 commits) (flutter/engine#7810) 347d690 Add support for new Scenic clip planes. (flutter/engine#7804) 309b90c Roll src/third_party/skia 14d64dd4c47c..66f09a72995a (8 commits) (flutter/engine#7805) 1dead52 Roll src/third_party/skia 0b6ae6386d34..14d64dd4c47c (10 commits) (flutter/engine#7802) 74d94e5 Revert "Use all font managers to discover fonts for strut. (#7734)" (flutter/engine#7801) 769016c Roll src/third_party/skia 63d477cd99b0..0b6ae6386d34 (9 commits) (flutter/engine#7798) f7eb3cb Roll src/third_party/skia 217acf58d0d8..63d477cd99b0 (1 commits) (flutter/engine#7797) c4a5555 Use all font managers to discover fonts for strut. (flutter/engine#7734) 17b7d1e Roll src/third_party/dart 754e5f404c..ecd7a88606 (8 commits) b4ed8cf Roll src/third_party/skia 233fc0b03c02..217acf58d0d8 (1 commits) (flutter/engine#7795) 27ab9f7 Roll src/third_party/skia 454e5fb7457d..233fc0b03c02 (4 commits) (flutter/engine#7794) c58f5fe Roll src/third_party/dart fdfe40ea95..754e5f404c (13 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
4 participants
This is necessary for Flutter to build on the next Dart roll.
It should be landed before then, however.