Add accessibility semantics support to embedder by cbracken · Pull Request #7891 · flutter/engine

cbracken · 2019-02-20T22:59:15Z

Flutter's accessibility APIs consist of three main calls from the
embedder to the Dart application:

FlutterEngineUpdateSemanticsEnabled: enables/disables semantics support.
FlutterEngineUpdateAccessibilityFeatures: sets embedder-specific
accessibility features.
FlutterEngineDispatchSemanticsAction: dispatches an action (tap,
long-press, scroll, etc.) to a semantics node.

and two main callbacks triggered by Dart code:

FlutterUpdateSemanticsNodeCallback: notifies the embedder of
updates to the properties of a given semantics node.
FlutterUpdateSemanticsCustomActionCallback: notifies the embedder
of updates to custom semantics actions registered in Dart code.

In the Flutter framework, when accessibility is first enabled, the
embedder will receive a stream of update callbacks notifying the
embedder of the full semantics tree. On further changes in the Dart
application, only updates will be sent.

chinmaygarde

Some minor nits, but lgtm.

chinmaygarde · 2019-02-20T23:15:28Z

shell/platform/embedder/embedder_engine.cc

+    return false;
+  }
+  shell_->GetTaskRunners().GetUITaskRunner()->PostTask(
+      [engine = shell_->GetEngine(), id, action = std::move(action),


Nit: action is just an int32_t. The move is not necessary.

Done. Nice catch; not sure how many times I had to refresh my mind this was an enum and not some messy struct :)

chinmaygarde · 2019-02-20T23:16:35Z

shell/platform/embedder/embedder_engine.cc

+  }
+  shell_->GetTaskRunners().GetUITaskRunner()->PostTask(
+      [engine = shell_->GetEngine(), id, action = std::move(action),
+       args = std::move(args)] {


If you are attempting to prevent a copy of the args vector, then this code does not avoid the same. You can use fml::MakeCopyable with a mutable lambda to achieve it though.

shell/platform/embedder/embedder.h

goderbauer · 2019-02-20T23:39:43Z

The license script is unhappy :(

cbracken · 2019-02-21T01:07:14Z

Updated docs and tweaked the type (and name) of FlutterSemanticsCustomAction.override_action (was override_id).

Flutter's accessibility APIs consist of three main calls from the embedder to the Dart application: 1. FlutterEngineUpdateSemanticsEnabled: enables/disables semantics support. 2. FlutterEngineUpdateAccessibilityFeatures: sets embedder-specific accessibility features. 3. FlutterEngineDispatchSemanticsAction: dispatches an action (tap, long-press, scroll, etc.) to a semantics node. and two main callbacks triggered by Dart code: 1. FlutterUpdateSemanticsNodeCallback: notifies the embedder of updates to the properties of a given semantics node. 2. FlutterUpdateSemanticsCustomActionCallback: notifies the embedder of updates to custom semantics actions registered in Dart code. In the Flutter framework, when accessibility is first enabled, the embedder will receive a stream of update callbacks notifying the embedder of the full semantics tree. On further changes in the Dart application, only updates will be sent.

cbracken · 2019-02-21T08:30:37Z

Fixes flutter/flutter#24789.

…ne#7891)

flutter/engine@293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900) flutter/engine@6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899) flutter/engine@6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter#7895) flutter/engine@39f7066b6 Test profile and release build and unit tests (flutter/engine#7880) flutter/engine@abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891) flutter/engine@ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894) flutter/engine@684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893) flutter/engine@e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878) flutter/engine@2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892) flutter/engine@8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863) flutter/engine@61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits) flutter/engine@b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889) flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter#7886)

…ne#7891)

flutter/engine@f1f19bba8 Revert "Revert "Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895)" (flutter/engine#7911)" (flutter/engine#7916) flutter/engine@5db4b3772 Revert dart rolls (flutter/engine#7913) flutter/engine@0053c1d50 Roll src/third_party/dart 75ee523f91..4cff5a4fd6 (6 commits) flutter/engine@8620579cf Roll src/third_party/skia 9a049e6ce39d..63c4d3596915 (8 commits) (flutter/engine#7909) flutter/engine@aa2b287cb Reland flutter/engine#7777 with proper LICENSE (flutter/engine#7888) flutter/engine@a5773d121 Do not add ghost runs for trailing whitespace if the text is ellipsized (flutter/engine#7906) flutter/engine@93eeb48ba Revert "Revert "Remove unnecessary entry-point closurization. (flutter/engine#7827)" (flutter/engine#7876)" (flutter/engine#7904) flutter/engine@bbaeba3f3 Roll src/third_party/skia 05ff93c43ea5..9a049e6ce39d (11 commits) (flutter/engine#7903) flutter/engine@1cf6b8b64 Roll src/third_party/dart 5ddd157809..75ee523f91 (19 commits) flutter/engine@be32040ef Roll src/third_party/skia 348227b89430..05ff93c43ea5 (2 commits) (flutter/engine#7901) flutter/engine@293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900) flutter/engine@6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899) flutter/engine@6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895) flutter/engine@39f7066b6 Test profile and release build and unit tests (flutter/engine#7880) flutter/engine@abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891) flutter/engine@ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894) flutter/engine@684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893) flutter/engine@e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878) flutter/engine@2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892) flutter/engine@8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863) flutter/engine@61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits) flutter/engine@b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889) flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter/engine#7886) flutter/engine@dad6ec01c Correct onAccessibilityFeaturesChanged docs (flutter/engine#7883)

…ne#7891)

flutter/engine@f1f19bba8 Revert "Revert "Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895)" (flutter/engine#7911)" (flutter/engine#7916) flutter/engine@5db4b3772 Revert dart rolls (flutter/engine#7913) flutter/engine@0053c1d50 Roll src/third_party/dart 75ee523f91..4cff5a4fd6 (6 commits) flutter/engine@8620579cf Roll src/third_party/skia 9a049e6ce39d..63c4d3596915 (8 commits) (flutter/engine#7909) flutter/engine@aa2b287cb Reland flutter/engine#7777 with proper LICENSE (flutter/engine#7888) flutter/engine@a5773d121 Do not add ghost runs for trailing whitespace if the text is ellipsized (flutter/engine#7906) flutter/engine@93eeb48ba Revert "Revert "Remove unnecessary entry-point closurization. (flutter/engine#7827)" (flutter/engine#7876)" (flutter/engine#7904) flutter/engine@bbaeba3f3 Roll src/third_party/skia 05ff93c43ea5..9a049e6ce39d (11 commits) (flutter/engine#7903) flutter/engine@1cf6b8b64 Roll src/third_party/dart 5ddd157809..75ee523f91 (19 commits) flutter/engine@be32040ef Roll src/third_party/skia 348227b89430..05ff93c43ea5 (2 commits) (flutter/engine#7901) flutter/engine@293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900) flutter/engine@6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899) flutter/engine@6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895) flutter/engine@39f7066b6 Test profile and release build and unit tests (flutter/engine#7880) flutter/engine@abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891) flutter/engine@ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894) flutter/engine@684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893) flutter/engine@e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878) flutter/engine@2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892) flutter/engine@8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863) flutter/engine@61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits) flutter/engine@b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889) flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter/engine#7886) flutter/engine@dad6ec01c Correct onAccessibilityFeaturesChanged docs (flutter/engine#7883)

cbracken requested review from chinmaygarde and goderbauer February 20, 2019 22:59

googlebot added the cla: yes label Feb 20, 2019

chinmaygarde approved these changes Feb 20, 2019

View reviewed changes

goderbauer reviewed Feb 20, 2019

View reviewed changes

shell/platform/embedder/embedder.h Show resolved Hide resolved

shell/platform/embedder/embedder.h Show resolved Hide resolved

shell/platform/embedder/embedder.h Show resolved Hide resolved

cbracken merged commit abe9826 into flutter:master Feb 21, 2019

cbracken deleted the embedder-a11y branch February 21, 2019 02:59

stuartmorgan-g mentioned this pull request Feb 21, 2019

[macOS] Support VoiceOver google/flutter-desktop-embedding#40

Closed

cbracken mentioned this pull request Feb 21, 2019

Expose accessibility APIs via Flutter Embedder API flutter/flutter#24789

Closed

engine-flutter-autoroll mentioned this pull request Feb 21, 2019

Roll engine 6d7eb52185b1..293b3de986d4 (12 commits) flutter/flutter#28253

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

10b404d

…ne#7891)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

df603cf

…ne#7891)

engine-flutter-autoroll mentioned this pull request Feb 21, 2019

Roll engine 6d7eb52185b1..1cf6b8b64d42 (14 commits) flutter/flutter#28268

Closed

cbracken mentioned this pull request Feb 21, 2019

Roll engine to be32040efda249a0dd05640a3f4bca567ef43bd0 flutter/flutter#28269

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

5a1ed3d

…ne#7891)

engine-flutter-autoroll mentioned this pull request Feb 21, 2019

Roll engine 6d7eb52185b1..bbaeba3f35c3 (15 commits) flutter/flutter#28275

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

4983085

…ne#7891)

engine-flutter-autoroll mentioned this pull request Feb 21, 2019

Roll engine 6d7eb52185b1..93eeb48baee5 (16 commits) flutter/flutter#28276

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

3910ff4

…ne#7891)

engine-flutter-autoroll mentioned this pull request Feb 21, 2019

Roll engine 6d7eb52185b1..a5773d12116f (17 commits) flutter/flutter#28282

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

8494ad0

…ne#7891)

engine-flutter-autoroll mentioned this pull request Feb 21, 2019

Roll engine 6d7eb52185b1..aa2b287cbf68 (18 commits) flutter/flutter#28289

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

860e247

…ne#7891)

engine-flutter-autoroll mentioned this pull request Feb 22, 2019

Roll engine 6d7eb52185b1..0053c1d50649 (20 commits) flutter/flutter#28293

Closed

cbracken mentioned this pull request Feb 22, 2019

Roll the engine to 5db4b377244bae48bc21e449e616417e68c9a6b9 flutter/flutter#28296

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

d37badb

…ne#7891)

engine-flutter-autoroll mentioned this pull request Feb 22, 2019

Roll engine 6d7eb52185b1..f1f19bba8f00 (23 commits) flutter/flutter#28301

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2019

abe9826 Add accessibility semantics support to embedder (flutter/engi…

45913a2

…ne#7891)

engine-flutter-autoroll mentioned this pull request Feb 22, 2019

Roll engine 6d7eb52185b1..043d92c48abd (24 commits) flutter/flutter#28304

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add accessibility semantics support to embedder#7891

Add accessibility semantics support to embedder#7891
cbracken merged 1 commit intoflutter:masterfrom
cbracken:embedder-a11y

cbracken commented Feb 20, 2019

Uh oh!

chinmaygarde left a comment

Uh oh!

chinmaygarde Feb 20, 2019

Uh oh!

cbracken Feb 20, 2019

Uh oh!

chinmaygarde Feb 20, 2019

Uh oh!

cbracken Feb 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goderbauer commented Feb 20, 2019

Uh oh!

cbracken commented Feb 21, 2019

Uh oh!

cbracken commented Feb 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cbracken commented Feb 20, 2019

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

cbracken Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

cbracken Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goderbauer commented Feb 20, 2019

Uh oh!

cbracken commented Feb 21, 2019

Uh oh!

cbracken commented Feb 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants