Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Bugfix: Prevent crash when responding to a platform message after FlutterJNI detaches from native.#8170

Merged
matthew-carroll merged 1 commit intoflutter:masterfrom
matthew-carroll:bugfix_28651_flutterjni_crash_because_detached
Mar 15, 2019
Merged

Bugfix: Prevent crash when responding to a platform message after FlutterJNI detaches from native.#8170
matthew-carroll merged 1 commit intoflutter:masterfrom
matthew-carroll:bugfix_28651_flutterjni_crash_because_detached

Conversation

@matthew-carroll
Copy link
Contributor

@matthew-carroll matthew-carroll commented Mar 14, 2019

Bugfix: Prevent crash when responding to a platform message after FlutterJNI detaches from native (#28651).

mklim
mklim approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit b32d0ab into flutter:master Mar 15, 2019
@matthew-carroll matthew-carroll mentioned this pull request Mar 15, 2019
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2019
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2019
@engine-flutter-autoroll
b32d0ab Bugfix: Prevent crash when responding to a platform message a…
2e7cad1 
…fter FlutterJNI detaches from native (flutter#28651). (flutter/engine#8170)
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 15, 2019
@engine-flutter-autoroll
Roll engine 403337e..b36068c (10 commits) (#29429)
f6e9afa 
flutter/engine@403337e...b36068c

git log 403337e..b36068c --no-merges --oneline
b36068c Roll src/third_party/skia 05201fc7e77e..aefecad7c0d2 (5 commits) (flutter/engine#8176)
b32d0ab Bugfix: Prevent crash when responding to a platform message after FlutterJNI detaches from native (#28651). (flutter/engine#8170)
d9b2f09 Roll src/third_party/skia 512e38091c85..05201fc7e77e (10 commits) (flutter/engine#8173)
4b01d79 Add frame and target time metadata to vsync events and connect platform vsync events using flows. (flutter/engine#8172)
f7a0922 [fuchsia] Remove deprecated libraries from snapshot (flutter/engine#8085)
09db84f Android Embedding PR 19: Add accessibility to new FlutterView. (flutter/engine#8109)
246f0e3 Add an allocator specific check to ensure that strings passed to the timeline are not heap allocated. (flutter/engine#8168)
7a6bb99 Roll src/third_party/skia feb720f746dc..512e38091c85 (11 commits) (flutter/engine#8169)
5825bda Roll src/third_party/dart 7d560f8385..7418238239 (61 commits)
66fdeb1 Add dump-shader-skp switch to help ShaderWarmUp (flutter/engine#8148)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
RBogie pushed a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
@matthew-carroll @RBogie
Bugfix: Prevent crash when responding to a platform message after Flu…
dcbf54e 
…tterJNI detaches from native (flutter#28651). (flutter#8170)
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
@RBogie
Revert "Bugfix: Prevent crash when responding to a platform message a…
905c8ec 
…fter FlutterJNI detaches from native (flutter#28651). (flutter#8170)"

This reverts commit dcbf54e.
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
@RBogie
Revert "Bugfix: Prevent crash when responding to a platform message a…
7eb6784 
…fter FlutterJNI detaches from native (flutter#28651). (flutter#8170)"

This reverts commit dcbf54e.
@amr-ismael
Copy link

amr-ismael commented Nov 28, 2019 •
edited
Loading

I still got this error after Sign Up or Sign in to the firebsae , and after Sign Up the app crash but the email get restored in Fire Base ...

my flutter version is v1.9.1+hotfix.6

[ Tried to send a platform message to Flutter, but FlutterJNI was detached from native C++. Could not send. Channel: flutter/textinput. Response ID: 0 ]

W/BiChannelGoogleApi( 496): [FirebaseAuth: ] getGoogleApiForMethod() returned Gms: com.google.firebase.auth.api.internal.zzak@84089f1
E/JavaBinder( 496): *** Uncaught remote exception! (Exceptions are not yet supported across processes.)
E/JavaBinder( 496): java.lang.NoClassDefFoundError: Failed resolution of: Landroid/support/v4/util/ArrayMap;
E/JavaBinder( 496): at com.google.firebase.auth.internal.zzam.zzc(Unknown Source:22)
E/JavaBinder( 496): at com.google.firebase.auth.internal.zzam.zzde(Unknown Source:17)
E/JavaBinder( 496): at com.google.firebase.auth.internal.zzam.zzdd(Unknown Source:8)
E/JavaBinder( 496): at com.google.firebase.auth.internal.zzan.zzdf(Unknown Source:1)
E/JavaBinder( 496): at com.google.firebase.auth.internal.zzm.isAnonymous(Unknown Source:47)
E/JavaBinder( 496): at com.google.firebase.auth.internal.zzat.zzi(Unknown Source:57)
E/JavaBinder( 496): at com.google.firebase.auth.internal.zzat.zzg(Unknown Source:10)
E/JavaBinder( 496): at com.google.firebase.auth.FirebaseAuth.zza(Unknown Source:62)
E/JavaBinder( 496): at com.google.firebase.auth.FirebaseAuth$zzb.zza(Unknown Source:5)
E/JavaBinder( 496): at com.google.firebase.auth.api.internal.zzcr.zzdx(Unknown Source:15)
E/JavaBinder( 496): at com.google.firebase.auth.api.internal.zzen.zzen(Unknown Source:35)
E/JavaBinder( 496): at com.google.firebase.auth.api.internal.zzen.zza(Unknown Source:41)
E/JavaBinder( 496): at com.google.firebase.auth.api.internal.zzep.zza(Unknown Source:9)
E/JavaBinder( 496): at com.google.firebase.auth.api.internal.zzdx.dispatchTransaction(Unknown Source:9)
E/JavaBinder( 496): at com.google.android.gms.internal.firebase_auth.zza.onTransact(Unknown Source:13)
E/JavaBinder( 496): at android.os.Binder.execTransact(Binder.java:697)
E/JavaBinder( 496): Caused by: java.lang.ClassNotFoundException: Didn't find class "android.support.v4.util.ArrayMap" on path: DexPathList[[zip file "/data/app/com.example.rating-7OLL74quYmiDrfgVaur7Mg==/base.apk"],nativeLibraryDirectories=[/data/app/com.example.rating-7OLL74quYmiDrfgVaur7Mg==/lib/x86, /data/app/com.example.rating-7OLL74quYmiDrfgVaur7Mg==/base.apk!/lib/x86, /system/lib, /vendor/lib]]
E/JavaBinder( 496): at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:125)
E/JavaBinder( 496): at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
E/JavaBinder( 496): at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
E/JavaBinder( 496): ... 16 more
E/AndroidRuntime( 496): FATAL EXCEPTION: Binder:496_2
E/AndroidRuntime( 496): Process: com.example.rating, PID: 496
E/AndroidRuntime( 496): java.lang.NoClassDefFoundError: Failed resolution of: Landroid/support/v4/util/ArrayMap;
E/AndroidRuntime( 496): at com.google.firebase.auth.internal.zzam.zzc(Unknown Source:22)
E/AndroidRuntime( 496): at com.google.firebase.auth.internal.zzam.zzde(Unknown Source:17)
E/AndroidRuntime( 496): at com.google.firebase.auth.internal.zzam.zzdd(Unknown Source:8)
E/AndroidRuntime( 496): at com.google.firebase.auth.internal.zzan.zzdf(Unknown Source:1)
E/AndroidRuntime( 496): at com.google.firebase.auth.internal.zzm.isAnonymous(Unknown Source:47)
E/AndroidRuntime( 496): at com.google.firebase.auth.internal.zzat.zzi(Unknown Source:57)
E/AndroidRuntime( 496): at com.google.firebase.auth.internal.zzat.zzg(Unknown Source:10)
E/AndroidRuntime( 496): at com.google.firebase.auth.FirebaseAuth.zza(Unknown Source:62)
E/AndroidRuntime( 496): at com.google.firebase.auth.FirebaseAuth$zzb.zza(Unknown Source:5)
E/AndroidRuntime( 496): at com.google.firebase.auth.api.internal.zzcr.zzdx(Unknown Source:15)
E/AndroidRuntime( 496): at com.google.firebase.auth.api.internal.zzen.zzen(Unknown Source:35)
E/AndroidRuntime( 496): at com.google.firebase.auth.api.internal.zzen.zza(Unknown Source:41)
E/AndroidRuntime( 496): at com.google.firebase.auth.api.internal.zzep.zza(Unknown Source:9)
E/AndroidRuntime( 496): at com.google.firebase.auth.api.internal.zzdx.dispatchTransaction(Unknown Source:9)
E/AndroidRuntime( 496): at com.google.android.gms.internal.firebase_auth.zza.onTransact(Unknown Source:13)
E/AndroidRuntime( 496): at android.os.Binder.execTransact(Binder.java:697)
E/AndroidRuntime( 496): Caused by: java.lang.ClassNotFoundException: Didn't find class "android.support.v4.util.ArrayMap" on path: DexPathList[[zip file "/data/app/com.example.rating-7OLL74quYmiDrfgVaur7Mg==/base.apk"],nativeLibraryDirectories=[/data/app/com.example.rating-7OLL74quYmiDrfgVaur7Mg==/lib/x86, /data/app/com.example.rating-7OLL74quYmiDrfgVaur7Mg==/base.apk!/lib/x86, /system/lib, /vendor/lib]]
E/AndroidRuntime( 496): at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:125)
E/AndroidRuntime( 496): at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
E/AndroidRuntime( 496): at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
E/AndroidRuntime( 496): ... 16 more
D/EGL_emulation( 496): eglMakeCurrent: 0xe2a85b40: ver 2 0 (tinfo 0xcc7feec0)
W/libEGL ( 496): eglTerminate() called w/ 1 objects remaining
W/FlutterJNI( 496): Tried to send a platform message to Flutter, but FlutterJNI was detached from native C++. Could not send. Channel: flutter/textinput. Response ID: 0

@matthew-carroll
Copy link
Contributor Author

matthew-carroll commented Dec 3, 2019

@amr11mahmoud if you're having an issue, would you mind filing a new ticket with appropriate flutter doctor info and reproduction steps?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

2 more reviewers

@mklim mklim mklim approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matthew-carroll @amr-ismael @mklim @jason-simmons @googlebot