This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Keep overlays_gr_context_ in sync with the overlay surface#8175
Merged
iskakaushik merged 1 commit intoflutter:masterfrom Mar 15, 2019
Merged
Keep overlays_gr_context_ in sync with the overlay surface#8175iskakaushik merged 1 commit intoflutter:masterfrom
iskakaushik merged 1 commit intoflutter:masterfrom
Conversation
There can be cases where SubmitFrame gets called before overlays are a part of the frame, in these cases, we should not update the GRContext ahead of time. This commit makes it so we will update it only when the frame really shows the overlay. This addresses: flutter/flutter#28920
amirh
approved these changes
Mar 15, 2019
iskakaushik
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 15, 2019
flutter/engine@b36068c...cad97fe git log b36068c..cad97fe --no-merges --oneline cad97fe Update overlays_gr_context_ correctly (flutter/engine#8175) c0690e6 Roll src/third_party/skia aefecad7c0d2..69600007e278 (2 commits) (flutter/engine#8177) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
iskakaushik
added a commit
that referenced
this pull request
Mar 19, 2019
Layout occurs after [CATransaction commit]. layoutSubviews was where we set the contentsScale on the CALayer. This meant that for one frame, we would see content on the overlay view which was did not have the correct content scale. This change makes it so that we initialize the FlutterOverlayView with the correct contentsScale. This also updates the overlay_gr_context_ when we first create the overlay_view. This is an artifact of #8175. This manifests as jank as seen in: flutter/flutter#29573
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
There can be cases where SubmitFrame gets called before overlays are a part of the frame, in these cases, we should not update the GRContext ahead of time. This commit makes it so we will update it only when the frame really shows the overlay. This addresses: flutter/flutter#28920
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
Layout occurs after [CATransaction commit]. layoutSubviews was where we set the contentsScale on the CALayer. This meant that for one frame, we would see content on the overlay view which was did not have the correct content scale. This change makes it so that we initialize the FlutterOverlayView with the correct contentsScale. This also updates the overlay_gr_context_ when we first create the overlay_view. This is an artifact of flutter#8175. This manifests as jank as seen in: flutter/flutter#29573
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit aac8acd.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit aac8acd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we come back from the background, and have no platform view in the layer tree,
composition_order_will be empty. This would result inEnsureGLOverlayInitializedgetting called, butoverlays_gr_context_is falsely updated to the currentgr_context, which puts us in a state where we will not updateoverlays_gr_context_the next time we callEnsureGLOverlayInitializedwith non emptycomposition_order_.This manifests as flutter/flutter#28920