This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow running runtime_unittests in AOT mode.#8375
Merged
chinmaygarde merged 3 commits intoflutter:masterfrom Mar 30, 2019
Merged
Allow running runtime_unittests in AOT mode.#8375chinmaygarde merged 3 commits intoflutter:masterfrom
chinmaygarde merged 3 commits intoflutter:masterfrom
Conversation
jason-simmons
approved these changes
Mar 29, 2019
Member
|
Looks like the debug version of this test is now failing on Cirrus? |
GaryQian
reviewed
Mar 29, 2019
| }; | ||
|
|
||
| std::unique_ptr<AutoIsolateShutdown> RunDartCodeInIsolate( | ||
| static std::unique_ptr<AutoIsolateShutdown> RunDartCodeInIsolate( |
Contributor
There was a problem hiding this comment.
Is this meant to be static?
Contributor
Author
There was a problem hiding this comment.
Yes. This is just a utility method.
Contributor
Author
|
Fixed the debug variant. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 30, 2019
flutter/engine@ca7623e...b75472c git log ca7623e..b75472c --no-merges --oneline b75472c Add missing import to functional for Windows. (flutter/engine#8382) 9d71675 Ensure OpacityLayer to have a single child (flutter/engine#8362) 131cc62 Allow native entrypoint registration for runtime unittests. (flutter/engine#8379) 5e124ff Fix typos (flutter/engine#8339) 972afdc Allow running runtime_unittests in AOT mode. (flutter/engine#8375) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
Previously, only the most basic tests were run in AOT mode.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 3d720db.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 3d720db.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only the most basic tests were run in AOT mode.