This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll src/third_party/dart 907c514c89..1ad11facec (7 commits)#8459
Merged
Roll src/third_party/dart 907c514c89..1ad11facec (7 commits)#8459
Conversation
1ad11fa Fix mustCallSuper for mixins and inherited interfaces: 6dc9c8d [CFE] JS: Treat integer valued double constants as integers. dbfd00f [vm/compiler] Add new optimization pass which inlines typed data accesses dbc9ff1 [vm/vmservice] Switch from const bool.fromEnvironment() to new for 'DART_SERVICE_USE_AUTH'. 4479924 Revert "set empty environment defines to CompilerOptions" ec8222f bump to linter 0.1.84 d14990b Remove no-longer-needed override
Contributor
Author
|
Checks successful, automatically merging. |
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Apr 6, 2019
The dart revision 1ad11fa (rolled in flutter#8459) is causing engine-to-framework roll failure for the following two reasons: 1. analyze error: marked @mustCallSuper but does not invoke the overridden method 2. `flutter build aot` failure for examples/hello_world in build_tests-macos The 1. is likely due to dart-lang/sdk@1ad11fa and it easy to fix in the framework. However, the 2. is likely due to dart-lang/sdk@dbfd00f which I'm not sure how to fix. TBR: bkonyi
liyuqian
added a commit
that referenced
this pull request
Apr 6, 2019
The dart revision 1ad11fa (rolled in #8459) is causing engine-to-framework roll failure for the following two reasons: 1. analyze error: marked @mustCallSuper but does not invoke the overridden method 2. `flutter build aot` failure for examples/hello_world in build_tests-macos The 1. is likely due to dart-lang/sdk@1ad11fa and it easy to fix in the framework. However, the 2. is likely due to dart-lang/sdk@dbfd00f which I'm not sure how to fix. TBR: bkonyi
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
The dart revision 1ad11fa (rolled in flutter#8459) is causing engine-to-framework roll failure for the following two reasons: 1. analyze error: marked @mustCallSuper but does not invoke the overridden method 2. `flutter build aot` failure for examples/hello_world in build_tests-macos The 1. is likely due to dart-lang/sdk@1ad11fa and it easy to fix in the framework. However, the 2. is likely due to dart-lang/sdk@dbfd00f which I'm not sure how to fix. TBR: bkonyi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request which will automatically merge once checks pass.
Roll src/third_party/dart 907c514..1ad11fa (7 commits)
1ad11fa Fix mustCallSuper for mixins and inherited interfaces:
6dc9c8d [CFE] JS: Treat integer valued double constants as integers.
dbfd00f [vm/compiler] Add new optimization pass which inlines typed data accesses
dbc9ff1 [vm/vmservice] Switch from const bool.fromEnvironment() to new for 'DART_SERVICE_USE_AUTH'.
4479924 Revert "set empty environment defines to CompilerOptions"
ec8222f bump to linter 0.1.84
d14990b Remove no-longer-needed override