This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement StandardMethodCodec for C++ shells#8598
Merged
stuartmorgan-g merged 8 commits intoflutter:masterfrom Apr 17, 2019
Merged
Implement StandardMethodCodec for C++ shells#8598stuartmorgan-g merged 8 commits intoflutter:masterfrom
stuartmorgan-g merged 8 commits intoflutter:masterfrom
Conversation
chinmaygarde
approved these changes
Apr 17, 2019
Contributor
|
The client wrapper unit-tests don't seem to be wired up on the trybots or the LUCI bots. |
Contributor
Author
Doh! Good catch. That was blocked for a long time on getting the Linux builds actually enabled, and then I lost track of it. I'll get that added to the appropriate script(s). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
This was referenced Apr 17, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 17, 2019
flutter/engine@388124f...fdd4272 git log 388124f..fdd4272 --no-merges --oneline fdd4272 Roll src/third_party/skia 70ed05e53ad2..652b007a4cbb (1 commits) (flutter/engine#8601) 3b01610 Check that TransformLayer has a finite matrix (flutter/engine#8585) 4805d72 Implement StandardMethodCodec for C++ shells (flutter/engine#8598) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds StandardMethodCodec support to the C++ client wrapper. This makes it
substantially easier to add Windows and Linux support for existing plugins, as
StandardMethodCodec is the default plugin protocol.
Fixes flutter/flutter#30670
Does not include extensibility for the codec, which will be added later.