Add Rect.fromCenter() constructor#8716
Add Rect.fromCenter() constructor#8716tvolkert merged 6 commits intoflutter:masterfrom tvolkert:fromCenter
Conversation
jamesderlin
left a comment
jamesderlin
left a comment
There was a problem hiding this comment.
Is there a reason why it can't be const? (Rect.fromCircle and from Rect.fromPoints are also not const.) Maybe also consider if Rect.fromCircle should now delegate to Rect.fromCenter?
Because they refer to I updated PTAL |
Ah. It is unintuitive that getters on an immutable object that has a const constructor can't propagate const-ness. =( (Do you know why are Offset.dx/dy are getters instead of just being LGTM. |
|
Both fields and getters are virtual in Dart, it would make no difference anyway |
Done |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
For now we'll need to add an implementation of this constructor to stub_ui or framework code which uses it will fail to compile with dart2js
|
Please wait until internal embedders have been updated before making use of this in framework code. |
flutter/engine@7471dde...0c9c293 git log 7471dde..0c9c293 --no-merges --oneline 0c9c293 Add Rect.fromCenter() constructor (flutter/engine#8716) 74abe29 Roll src/third_party/skia 8413ff13fefa..b14574924ab3 (4 commits) (flutter/engine#8745) 95fd36c Roll src/third_party/dart 1f1592edce..e70273c306 (78 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
5 participants
No description provided.