This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix the iOS accessibility tree structure of platform views.#8731
Merged
cyanglaz merged 2 commits intoflutter:masterfrom May 9, 2019
Merged
Fix the iOS accessibility tree structure of platform views.#8731cyanglaz merged 2 commits intoflutter:masterfrom
cyanglaz merged 2 commits intoflutter:masterfrom
Conversation
Member
|
Looks like the PR description is missing the actual examples? |
Contributor
Author
Sorry about that, updated! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 10, 2019
flutter/engine@f1f95f9...d8646ed git log f1f95f9..d8646ed --no-merges --oneline d8646ed Fix the iOS accessibility tree structure of platform views. (flutter/engine#8731) b3e32e7 Roll src/third_party/skia dbded16fadde..4f6eb15178d8 (7 commits) (flutter/engine#8922) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
…8731) Partially fix the issue in flutter/flutter#30804. This only fixes the focus issue for other platform views (Google maps and other custom platform views), but the same issue on WebView is not fixed. Before the change, the a11y tree with platform view looks like ``` <some parent a11y container> <SemanticsObject for platform view> <FlutterPlatformViewSemanticsContainer> <platform view> ``` After the change, it looks like ``` <some parent a11y container> <FlutterPlatformViewSemanticsContainer> <SemanticsObject> <platform view> ``` This PR also updated the implementation of FlutterPlatformViewSemanticsContainer to use A11yContainer protocol to implement the details on various a11y attribute including the accessibilityFrame and accessibilityScroll.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fix the issue in flutter/flutter#30804. This only fixes the focus issue for other platform views (Google maps and other custom platform views), but the same issue on WebView is not fixed.
Before the change, the a11y tree with platform view looks like
After the change, it looks like
This PR also updated the implementation of FlutterPlatformViewSemanticsContainer to use A11yContainer protocol to implement the details on various a11y attribute including the
accessibilityFrameandaccessibilityScroll.As for the issue on WebView, I haven't found a good solution because the issue seems to be within the cocoa touch's WKWebView.