This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Log the sticky error during isolate shutdown#8742
Merged
jason-simmons merged 1 commit intoflutter:masterfrom Apr 25, 2019
Merged
Log the sticky error during isolate shutdown#8742jason-simmons merged 1 commit intoflutter:masterfrom
jason-simmons merged 1 commit intoflutter:masterfrom
Conversation
The sticky error may be set in cases such as an unhandled asynchronous exception. This is similar to the logging done in the Dart command line embedder's isolate shutdown callback.
Member
|
Dart ref/rationale for future archaeologists: https://dart-review.googlesource.com/c/sdk/+/52680/ |
chinmaygarde
approved these changes
Apr 25, 2019
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Don't you want to log the error when its fatal (especially)?
Member
Author
|
The intent is to log uncaught exceptions raised by the isolate. Fatal errors would indicate that the isolate was stopped by the embedder or by |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 26, 2019
flutter/engine@0c9c293...86c1329 git log 0c9c293..86c1329 --no-merges --oneline 86c1329 Roll src/third_party/skia b14574924ab3..ff7006ff8082 (2 commits) (flutter/engine#8748) 9bc5e0b Roll src/third_party/dart e70273c306..9a07ad88f4 (5 commits) 1502300 Log the sticky error during isolate shutdown (flutter/engine#8742) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sticky error may be set in cases such as an unhandled asynchronous
exception. This is similar to the logging done in the Dart command line
embedder's isolate shutdown callback.