This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2019
This was referenced May 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 13, 2019
flutter/engine@f4d23ef...904cfc4 git log f4d23ef..904cfc4 --no-merges --oneline 904cfc4 Add @UiThread to MethodChannel and related classes/calls (#32642). (flutter/engine#8947) c9406d4 Roll src/third_party/skia d696f8e6bca3..0221e8b22687 (5 commits) (flutter/engine#8948) 1b649a5 update docs (flutter/engine#8928) 47fd66c Terminate debug background task on expiry (flutter/engine#8930) 14c82d9 Only cache required frames (flutter/engine#8837) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Contributor
|
Might be worth going into more detail about what "rise over run units" are. |
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#32323
Unfortunately, this API is inconsistent and it seems too late to correct it - unless we really think this is worth a breaking change.