Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add @UiThread to MethodChannel and related classes/calls (#32642).#8947

Merged
matthew-carroll merged 1 commit intoflutter:masterfrom
matthew-carroll:32642_add_uithread_annotation_to_methodchannel
May 13, 2019
Merged

Add @UiThread to MethodChannel and related classes/calls (#32642).#8947
matthew-carroll merged 1 commit intoflutter:masterfrom
matthew-carroll:32642_add_uithread_annotation_to_methodchannel

Conversation

@matthew-carroll
Copy link
Contributor

Add @UiThread to MethodChannel and related classes/calls (#32642).

Requested by internal customer due to threading failures in tests.

@matthew-carroll
Copy link
Contributor Author

Bug that I filed for this issue is a dup of flutter/flutter#32623

@matthew-carroll matthew-carroll requested a review from mehmetf May 13, 2019 20:04
@matthew-carroll matthew-carroll merged commit 904cfc4 into flutter:master May 13, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request May 13, 2019
flutter/engine@f4d23ef...904cfc4

git log f4d23ef..904cfc4 --no-merges --oneline
904cfc4 Add @UiThread to MethodChannel and related classes/calls (#32642). (flutter/engine#8947)
c9406d4 Roll src/third_party/skia d696f8e6bca3..0221e8b22687 (5 commits) (flutter/engine#8948)
1b649a5 update docs (flutter/engine#8928)
47fd66c Terminate debug background task on expiry (flutter/engine#8930)
14c82d9 Only cache required frames (flutter/engine#8837)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
huqiuser pushed a commit to huqiuser/engine that referenced this pull request Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants