-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
flutter/engine
#32607Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Description
In context of dart-lang/sdk#48725 flutter seems to have its own copy of the zlib, which is different from what dart is using(which dart recently updated). Is flutter's own copy really needed, can this dependency pulled from dart sdk, automatically updated if dart sdk rolls its dependency?
- Remove third_party checked in code form buildroot #39532 where flutter zlib was moved from source code to flutter.googlesource.com, Update buildroot to d45d8382665c9. engine#30298 where buildroot was bumped.
- https://github.com/flutter/engine/blob/main/DEPS#L414 is where flutter engine points to flutter.googlesource.com copy of zlib
- https://github.com/dart-lang/sdk/blob/main/DEPS#L260 is where dart sdk points to chromium copy of zlib(which was updated to include security fix).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.