-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testscustomer: googleVarious Google teamsVarious Google teamsframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
b/238879865
MinimumTapTargetGuideline has logic to detect and skip elements that are scrolled partially off screen. However, this logic is flawed. It only checks for widgets that are at the edge of the physical screen, which omits the common case where the Scrollable container itself doesn't touch the edge of the screen.
Consider a screen with an AppBar and a long scrollable widget beneath it. Something like
Scaffold(
appBar: AppBar(title: Text('Foo')),
body: ListView(children: buildChildren()),
)
If a widget is partially visible at the top of the ListView, it will still be beneath the AppBar, not at the edge of the device screen, therefore it may fail the MinimumTapTargetGuideline erroneously.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testscustomer: googleVarious Google teamsVarious Google teamsframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.