Skip to content

[CP] Fix incorrect impellerc output file permissions #109233

@zanderso

Description

@zanderso

issue_link

#108737

Commit Hash

f047672

Target

beta

pr_link

flutter/engine#35186

Impacted Users

All devs targeting macOS

Impact Description

Incorrect file permissions cause failures on uploading macOS apps to Apple App Store. This will affect all app uploads since all apps bundle the ink_sparkle shader.

Workaround

Yes users can run:

$ chmod 0644 build/macos/Build/Products/Release/AppName.app/Contents/Frameworks/App.framework/Versions/A/Resources/flutter_assets/shaders/ink_sparkle.frag

however, the thought that this is difficult to document and error prone.

Risk

low

Test Coverage

yes

Validation Steps

Build an iOS app and check that access permissions on build/macos/Build/Products/Release/AppName.app/Contents/Frameworks/App.framework/Versions/A/Resources/flutter_assets/shaders/ink_sparkle.frag are 0644.

Tested in #109190.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cp: approvedApproved cherry-pick request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions