-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listgood first issueRelatively approachable for first-time contributorsRelatively approachable for first-time contributorsp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team
Description
At least the Dart generation, and probably all of the language generation, doesn't create the output file recursively. That leads to confusing flows like the following, which has bitten me several times:
- Set up Pigeon for the first time in a plugin that was simple enough to only have a
lib/plugin_name.dartfile with all of the implementation. - Configure the Dart to output to
lib/src/messages.g.dart. - Run Pigeon generation.
- Get an error about
lib/src/messages.g.dartnot existing. (The actual problem is thatlib/src/doesn't exist, so it can't make the file).
We should do a create(recursive: true) on the target File before trying to write to it.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listgood first issueRelatively approachable for first-time contributorsRelatively approachable for first-time contributorsp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team