-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.p: go_routerThe go_router packageThe go_router packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Description
(See #122713 for context.)
go_router and go_router_builder examples have several external dependencies:
adaptive_dialogprovider
which violates https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#dependencies
If these aren't critical to being able to provide a good example (I haven't looked at the details, but presumably they aren't), then we should remove them to reduce the repo's exposure.
(I've filed a single issue to group it, but they could certainly be removed individually, or only one removed if one is critical and the other isn't.)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.p: go_routerThe go_router packageThe go_router packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.