Skip to content

devicelab tests testing the flavors feature should test that assets _with_ a matching flavor are bundled #140432

New issue
New issue
Closed
#140433
Closed
devicelab tests testing the flavors feature should test that assets _with_ a matching flavor are bundled#140432
#140433
Assignees
andrewkolos
Labels
P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool team
@andrewkolos

Description

@andrewkolos
andrewkolos
opened on Dec 20, 2023

See

flutter/dev/devicelab/bin/tasks/flavors_test.dart

Lines 61 to 64 in d136976

if (assetManifest.containsKey('assets/free/free.txt')) {
return TaskResult.failure('Assets declared with a flavor not equal to the '
'argued --flavor value should not be bundled.');
}

and

flutter/dev/devicelab/bin/tasks/flavors_test_ios.dart

Lines 69 to 72 in d136976

if (assetManifest.containsKey('assets/free/free.txt')) {
return TaskResult.failure('Assets declared with a flavor not equal to the '
'argued --flavor value should not be bundled.');
}

In these tests, we are building the app with a --flavor of paid. The test code I just linked ensures that we don't bundle assets declared with a flavor of free. However, I think the tests should also test that an asset with a flavor of paid is bundled.

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions