-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
The golden image tests run at a scale of 1x, not high dpi. That means that if rendering is broken on high dpi, but works on 1x it won't get flagged. I think it's probably best if the golden image tests were changed to render at 2x dpi as opposed to running all the tests twice.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team