In https://dart-review.googlesource.com/c/sdk/+/356622 we updated the perfetto include directory in libprotozero_config to use `perfetto_root_path` rather than hardcoding `//third_party/perfetto`. Some Perfetto headers, however, #include a generated header, which is located at `$root_gen_dir/$perfetto_root_path/build_config`. See declaration of perfetto_build_flags.h and buildflag_gen_dir_ at: https://flutter.googlesource.com/third_party/perfetto/+/refs/heads/main/gn/BUILD.gn#26 This was missed in the first patch since while the default local engine build of Flutter DOES do all gn processing, it DOES NOT do a full Dart build, our presubmits however, revealed the gap. This updates the include directories for the config to use the correct value as declared in perfetto. TEST=None. Refactor only; no semantic changes. Issue: flutter/flutter#144204 Change-Id: I44c1269af85e40eab8e397c3d099f5dc1bca1229 Part of: flutter/flutter#67373 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356960 Commit-Queue: Chris Bracken <cbracken@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>

Migrate src/third_party/perfetto to src/flutter/third_party. #144204

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Migrate `src/third_party/perfetto` to `src/flutter/third_party`. #144204