ReplaceSurfaceProducer.Callback.onSurfaceCreated with onSurfaceAvailable when published to stable #155131
Description
Callback.SurfaceProducer.onSurfaceCreated reads:
Invoked when a previous surface is now invalid and a new surface is now available.
Unfortunately this (a) is not a true statement and (b) the method name sucks.
What this really is:
public FlutterRenderer(@NonNull FlutterJNI flutterJNI) {
this.flutterJNI = flutterJNI;
this.flutterJNI.addIsDisplayingFlutterUiListener(flutterUiDisplayListener);
ProcessLifecycleOwner.get()
.getLifecycle()
.addObserver(
new DefaultLifecycleObserver() {
@Override
public void onResume(@NonNull LifecycleOwner owner) {
Log.v(TAG, "onResume called; notifying SurfaceProducers");
for (ImageReaderSurfaceProducer producer : imageReaderProducers) {
if (producer.callback != null) {
producer.callback.onSurfaceCreated();
}
}
}
});
}A resume is not directly correlated with a surface creation.
Some possible ideas:
- Only call the method when the surface was previously destroyed
- Rename the method
onSurfaceAvailableoronSurfaceResumed