Skip to content

Support building Flutter test runner with GPU support disabled in Skia #17146

@petrhosek

Description

@petrhosek

We'd like to build Flutter test runner with GPU support disabled in Skia, by setting the skia_enable_gpu = false GN argument. However, today that results in the following error:

[12253/19539] CXX host_x64/obj/third_party/flutter/shell/gpu/gpu.gpu_surface_gl.o
FAILED: host_x64/obj/third_party/flutter/shell/gpu/gpu.gpu_surface_gl.o
../../buildtools/linux-x64/clang/bin/clang++ -MD -MF host_x64/obj/third_party/flutter/shell/gpu/gpu.gpu_surface_gl.o.d -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_PDF -DSK_HAS_PNG_LIBRARY -DSK_USE_SKCMS -DSK_XML -DFLUTTER_RUNTIME_MODE_DEBUG=1 -DFLUTTER_RUNTIME_MODE_PROFILE=2 -DFLUTTER_RUNTIME_MODE_RELEASE=3 -DFLUTTER_RUNTIME_MODE=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DENABLE_OPENTYPE_VERTICAL=1 -DSK_SAMPLES_FOR_X -DSK_DISABLE_EXPLICIT_GPU_RESOURCE_ALLOCATION -DSK_DISABLE_RENDER_TARGET_SORTING -DSK_SUPPORT_LEGACY_BACKEND_OBJECTS -DSK_DONT_OPTIMIZE_SRC_PROFILES_FOR_SPEED -DSK_DONT_OPTIMIZE_DST_PROFILES_FOR_SPEED -DSK_SUPPORT_GPU=0 -I../.. -Ihost_x64/gen -I../../third_party -I../../garnet/public -I../../peridot/public -I../../topaz/public -Ihost_x64/gen/garnet/public -Ihost_x64/gen/peridot/public -Ihost_x64/gen/topaz/public -I../../topaz -I../../third_party/dart/runtime -I../../third_party/skia/include/android -I../../third_party/skia/include/c -I../../third_party/skia/include/codec -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/gpu/gl -I../../third_party/skia/include/atlastext -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/svg -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -g --sysroot=/usr/local/google/home/phosek/fuchsia/buildtools/linux-x64/sysroot -fdebug-prefix-map=/usr/local/google/home/phosek/fuchsia=../.. -no-canonical-prefixes -Wall -Wextra -Wno-unused-parameter -fvisibility=hidden -g -Og -fvisibility-inlines-hidden -std=c++14 -stdlib=libc++ -fno-exceptions -fno-rtti -c ../../third_party/flutter/shell/gpu/gpu_surface_gl.cc -o host_x64/obj/third_party/flutter/shell/gpu/gpu.gpu_surface_gl.o
../../third_party/flutter/shell/gpu/gpu_surface_gl.cc:115:25: error: no matching constructor for initialization of 'GrBackendRenderTarget'
  GrBackendRenderTarget render_target(size.fWidth,      // width
                        ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/skia/include/gpu/GrBackendSurface.h:32:14: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 5 were provided
class SK_API GrBackendRenderTarget {
             ^
../../third_party/skia/include/gpu/GrBackendSurface.h:32:14: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 5 were provided
../../third_party/skia/include/gpu/GrBackendSurface.h:34:5: note: candidate constructor not viable: requires 0 arguments, but 5 were provided
    GrBackendRenderTarget() {}
    ^
1 error generated.
[12310/19539] ACTION //topaz/shell/userpicker_device_shell:userpicker_device_shell_dart_library_identify_sources(//build/dart:dartlang)
ninja: build stopped: subcommand failed.

This is when building Flutter test running for host as part of Fuchsia.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions