-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passp: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
Description
We've been seeing a lot of flake in flutter/packages wed tests recently with this failure in google_sign_in_web (example run):
Launching integration_test/flexible_size_html_element_view_test.dart on Web Server in debug mode...
Compiling integration_test/flexible_size_html_element_view_test.dart for the Web...
29.7s
✓ Built build/web
integration_test/flexible_size_html_element_view_test.dart is being served at http://localhost:7357
The web-server device requires the Dart Debug Chrome extension for debugging. Consider using the Chrome or Edge devices for an improved development workflow.
Failure Details:
Failure in method: empty case, calls onElementCreated
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following assertion was thrown running a test (but after the
test had completed):
Assertion failed:
org-dartlang-sdk:///lib/_engine/engine/platform_views/embedder.dart:303:27
debugInvalidViewIds == null || debugInvalidViewIds!.isEmpty
"Cannot render platform views: 0. These views have not been
created, or they have been deleted."
When the exception was thrown, this was the stack:
at module0.Error._throwWithCurrentStackTrace (http://localhost:7357/main.dart.wasm:wasm-function[737]:0x19fc6e)
at module0.AssertionError._throwWithMessage (http://localhost:7357/main.dart.wasm:wasm-function[742]:0x19fd4e)
at module0.PlatformViewEmbedder.submitFrame inner (http://localhost:7357/main.dart.wasm:wasm-function[13073]:0x275fb6)
at module0._awaitHelper closure at org-dartlang-sdk:///dart-sdk/lib/_internal/wasm/lib/async_patch.dart:104:5 (http://localhost:7357/main.dart.wasm:wasm-function[1434]:0x1ab755)
at module0.closure wrapper at org-dartlang-sdk:///dart-sdk/lib/_internal/wasm/lib/async_patch.dart:104:5 trampoline (http://localhost:7357/main.dart.wasm:wasm-function[1437]:0x1ab7d6)
at module0._rootRunUnary (http://localhost:7357/main.dart.wasm:wasm-function[1038]:0x1a415d)
at module0._rootRunUnary tear-off trampoline (http://localhost:7357/main.dart.wasm:wasm-function[6577]:0x1ff9b8)
at module0._CustomZone.runUnary (http://localhost:7357/main.dart.wasm:wasm-function[6440]:0x1fdf60)
═════════════════════════════════════════════════════════════════
I've been noticing in the _wasm variant of the web test bots, but I'm not 100% confident that it's only the wasm version failing.
This has been significantly impacting tree closure rates and presubmit flakes in flutter/packages, making it much harder to land PRs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passp: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team