-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
Labels
a: desktopRunning on desktopRunning on desktope: glfwGLFW desktop embeddingGLFW desktop embeddingengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-linuxBuilding on or for Linux specificallyBuilding on or for Linux specificallyplatform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically
Description
Currently the Windows and Linux GLFW embedding libraries and associated wrapper directory aren't using a suffix. This makes things confusing/difficult when we look at switching over to using the real, non-GLFW implementations, as we will be doing shortly for Windows.
To prepare for this, we need to:
- Add a copy of the libraries with
_glfwsuffixes (wrappers are already added) - Add those versions to the recipes that post artifacts
- Update
flutter_toolto get those versions instead (and make the corresponding changes to FDE examples) - Stop posting the un-suffixed Linux version in the recipe
- Remove the unsuffixed Linux version from the build, remove the
_win32suffix from the Windows library, remove thedirectory_suffixfrompublish_wrapper_windows, and removepublish_wrapper_unprefixed(actually unsuffixed; it was misnamed). This will have the effect of switch the recipes for Windows that aren't explicitly using_glfwartifacts from GLFW to Win32, except for the header - Switch the primary header included in
windows-x64-flutter.zip
Doing it this way should prevent any breaking changes that have to be simultaneously landed between the recipe repo and the engine repo.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
a: desktopRunning on desktopRunning on desktope: glfwGLFW desktop embeddingGLFW desktop embeddingengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-linuxBuilding on or for Linux specificallyBuilding on or for Linux specificallyplatform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically