Skip to content

AssetBundle.needsBuild(..) ignores deleted wildcard directories. #42230

@ghost

Description

asset.dart's needsBuild(..) {..} returns whether an AssetBundle needs to be (re)built given a corresponding manifest.
Its approach is to check the existence and modified timestamp on the manifest and its directories.
However, when checking the directories (_wildcardDirectories) it checks if modified returns null, in which case it skips the directory.
For MemoryFileSystem this unfortunately means that if a "wildcard dir" is deleted, needsBuild will simply ignore it and will likely return false.

I believe this is a bug as any major changes to the filesystem should likely indicate that the AssetBundle needs rebuilding?

Metadata

Metadata

Assignees

Labels

c: flakeTests that sometimes, but not always, incorrectly passengineflutter/engine related. See also e: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions