Skip to content

GeneratedPluginsRegistrant version matching for modules isn't strictly correct #44423

@xster

Description

@xster

plugins.dart's _getAndroidEmbeddingVersion() isn't strictly right for module types. The embedding version is determined by the AndroidManifest of the app but modules' embedding version should just be hardcoded to V2. The modules happens to have a lightweight wrapper app as an example whose AndroidManifest says v2 but it's more of a coincidence.

cc @blasten

We should probably fix it at the same time as #44245

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: existing-appsIntegration with existing apps via the add-to-app flowtoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions