-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecta: assetsPackaging, accessing, or using assetsPackaging, accessing, or using assetsa: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our teststeam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
Description
The test that currently lives in
flutter/packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart
Lines 58 to 74 in e03f439
| test('Does not leave stale files in build directory', () => testbed.run(() async { | |
| await buildSystem.build(const CopyAssets(), environment); | |
| expect(globals.fs.file(globals.fs.path.join(environment.buildDir.path, 'flutter_assets', 'assets/foo/bar.png')).existsSync(), true); | |
| // Modify manifest to remove asset. | |
| globals.fs.file('pubspec.yaml') | |
| ..createSync() | |
| ..writeAsStringSync(''' | |
| name: example | |
| flutter: | |
| '''); | |
| await buildSystem.build(const CopyAssets(), environment); | |
| // See https://github.com/flutter/flutter/issues/35293 | |
| expect(globals.fs.file(globals.fs.path.join(environment.buildDir.path, 'flutter_assets', 'assets/foo/bar.png')).existsSync(), false); | |
| }), skip: Platform.isWindows); // See https://github.com/google/file.dart/issues/131 |
should be moved to a build system test, since it really requires the whole build system to run. It will be removed in #49737 but should be added back to a place that makes sense in the build system.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecta: assetsPackaging, accessing, or using assetsPackaging, accessing, or using assetsa: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our teststeam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team