-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
Labels
a: internationalizationSupporting other languages or locales. (aka i18n)Supporting other languages or locales. (aka i18n)f: date/time pickerDate or time picker widgetsDate or time picker widgetsf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.found in release: 1.21Found to occur in 1.21Found to occur in 1.21frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version
Description
Steps to Reproduce
- Use the new
showTimePickerin Flutter 1.20 while the app is localized to brazilian portuguese (using the oficial documentation, localization delegates, etc.)
localizationsDelegates: const [
GlobalMaterialLocalizations.delegate,
GlobalWidgetsLocalizations.delegate,
GlobalCupertinoLocalizations.delegate,
],
supportedLocales: const [Locale("pt", "BR"), Locale("pt")],
locale: const Locale("pt", "BR"),Expected results:
Input mode:
- Hour and Minute are not translatable (there are no options in
showTimePicker). - CANCEL is capitalized (the new Material guideline recommends it to be lowercase, right?)
- If Ok and CANCEL are translated, why title is not? (not important, since title, ok and cancel can be manually translated)
- Error messages are also not translatable
- The current value should be selected when field get focus (so user just type the new value instead of having to delete it before edit)
- Use maxlength to allow only 2 characters
- It would be nice if we couldn't type 25 in hours, 61 in minutes, etc.
- It would be nice if there was a ⬆ and ⬇ buttons beneath each textbox (so user can use it to increment/decrement the value instead of typing it). Or, better yet: let us provide builders for each part of those dialogs.
Dial mode:
- I had users complaining about the old time picker because "it was not possible to pick times other than 00 - 12". My user didn't get that it was possible to pick times from 12 to 24h because Android time picker is not user friendly (at least to some users). The fact that the new time picker hides odd hours will lead to the same kind of issue in those... less intelectual gifted users. Please, consider putting all numbers in the clock (even if it is smaller than the others). It would be a plus if we could have builders for those numbers (so we can choose fonts, etc.).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
a: internationalizationSupporting other languages or locales. (aka i18n)Supporting other languages or locales. (aka i18n)f: date/time pickerDate or time picker widgetsDate or time picker widgetsf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.found in release: 1.21Found to occur in 1.21Found to occur in 1.21frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version


