-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team
Description
Today, both FlutterEngine and InputConnectionAdapter (and via that, FlutterTextUtils) create new FlutterJNI instances.
I'm pretty sure that only FlutterEngine needs one. InputConnectionAdaptor doesn't need any state, it's only using native methods that are stateless.
The only thing that isn't clear to me is whether we'd ever actually need two instances of FlutterJNI - I think there's some case where we'd want that but not today. But we should also make it clearer about when that'd be necessary, which methods care about state, etc.
/cc @xster @jason-simmons
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team