Skip to content

Engine clip layers have a lot of duplicated code #70406

New issue
New issue
Open
Open
Engine clip layers have a lot of duplicated code#70406
Labels
P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team
@flar

Description

@flar
flar
opened on Nov 12, 2020

There are 3 clipping subclasses of flutter::Layer in the engine and all 3 have nearly identical code except for a few lines that deal with the specific clip information:

  • ClipPathLayer
  • ClipRectLayer
  • ClipRRectLayer

We should probably have common code with the 3 variants represented by subclassing, templating, or a "clip shape" helper object.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions