This still reproducible on latest master channel since the test case is still being skipped and the TODO is still there.

flutter/packages/flutter/test/widgets/ensure_visible_test.dart

Lines 374 to 431 in f35a8b7

    
           // TODO(abarth): Unskip this test. See https://github.com/flutter/flutter/issues/7919 
        
           testWidgets('ListView ensureVisible negative child', (WidgetTester tester) async { 
        
             BuildContext findContext(int i) => tester.element(findKey(i)); 
        
             Future<void> prepare(double offset) async { 
        
               tester.state<ScrollableState>(find.byType(Scrollable)).position.jumpTo(offset); 
        
               await tester.pump(); 
        
             } 
        
             double getOffset() { 
        
               return tester.state<ScrollableState>(find.byType(Scrollable)).position.pixels; 
        
             } 
        
             Widget buildSliver(int i) { 
        
               return SliverToBoxAdapter( 
        
                 key: ValueKey<int>(i), 
        
                 child: const SizedBox(width: 200.0, height: 200.0), 
        
               ); 
        
             } 
        
             await tester.pumpWidget( 
        
               Directionality( 
        
                 textDirection: TextDirection.ltr, 
        
                 child: Center( 
        
                   child: SizedBox( 
        
                     width: 600.0, 
        
                     height: 400.0, 
        
                     child: Scrollable( 
        
                       viewportBuilder: (BuildContext context, ViewportOffset offset) { 
        
                         return Viewport( 
        
                           offset: offset, 
        
                           center: const ValueKey<int>(4), 
        
                           slivers: <Widget>[ 
        
                             buildSliver(0), 
        
                             buildSliver(1), 
        
                             buildSliver(2), 
        
                             buildSliver(3), 
        
                             buildSliver(4), 
        
                             buildSliver(5), 
        
                             buildSliver(6), 
        
                           ], 
        
                         ); 
        
                       }, 
        
                     ), 
        
                   ), 
        
                 ), 
        
               ), 
        
             ); 
        
             await prepare(-125.0); 
        
             Scrollable.ensureVisible(findContext(3)); 
        
             await tester.pump(); 
        
             expect(getOffset(), equals(-200.0)); 
        
             await prepare(-225.0); 
        
             Scrollable.ensureVisible(findContext(2)); 
        
             await tester.pump(); 
        
             expect(getOffset(), equals(-400.0)); 
        
           }, skip: true); // https://github.com/flutter/flutter/issues/7919

	// TODO(abarth): Unskip this test. See https://github.com/flutter/flutter/issues/7919
	testWidgets('ListView ensureVisible negative child', (WidgetTester tester) async {
	BuildContext findContext(int i) => tester.element(findKey(i));
	Future<void> prepare(double offset) async {
	tester.state<ScrollableState>(find.byType(Scrollable)).position.jumpTo(offset);
	await tester.pump();
	}

	double getOffset() {
	return tester.state<ScrollableState>(find.byType(Scrollable)).position.pixels;
	}

	Widget buildSliver(int i) {
	return SliverToBoxAdapter(
	key: ValueKey<int>(i),
	child: const SizedBox(width: 200.0, height: 200.0),
	);
	}

	await tester.pumpWidget(
	Directionality(
	textDirection: TextDirection.ltr,
	child: Center(
	child: SizedBox(
	width: 600.0,
	height: 400.0,
	child: Scrollable(
	viewportBuilder: (BuildContext context, ViewportOffset offset) {
	return Viewport(
	offset: offset,
	center: const ValueKey<int>(4),
	slivers: <Widget>[
	buildSliver(0),
	buildSliver(1),
	buildSliver(2),
	buildSliver(3),
	buildSliver(4),
	buildSliver(5),
	buildSliver(6),
	],
	);
	},
	),
	),
	),
	),
	);

	await prepare(-125.0);
	Scrollable.ensureVisible(findContext(3));
	await tester.pump();
	expect(getOffset(), equals(-200.0));

	await prepare(-225.0);
	Scrollable.ensureVisible(findContext(2));
	await tester.pump();
	expect(getOffset(), equals(-400.0));
	}, skip: true); // https://github.com/flutter/flutter/issues/7919

Make sure Scrollable.ensureVisible works with children before the center #7919

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions