Skip to content

Picture Cache complexity metrics should include nested SkPicture/DisplayList op counts #91621

@flar

Description

@flar

Right now we are only checking the op counts for the SkPicture or DisplayList that we are evaluating for the cache. But, if that Picture contains other nested Picture objects (via drawPicture() or drawDisplayList()) then the op counts for those nested pictures are ignored - they appear as a single "op".

Both SkPicture and DisplayList provide the mechanism to ask for the fully accumulated nested op counts (basically, passing in a flag to the method that provides the op counts) and we should be using that mechanism for our raster cache complexity metrics.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityc: performanceRelates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions