-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Closed
flutter/engine
#29265Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Description
Right now we are only checking the op counts for the SkPicture or DisplayList that we are evaluating for the cache. But, if that Picture contains other nested Picture objects (via drawPicture() or drawDisplayList()) then the op counts for those nested pictures are ignored - they appear as a single "op".
Both SkPicture and DisplayList provide the mechanism to ask for the fully accumulated nested op counts (basically, passing in a flag to the method that provides the op counts) and we should be using that mechanism for our raster cache complexity metrics.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Type
Projects
Status
✅ Done