Skip to content

Eliminate definition: _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING #93743

New issue
New issue
Open
Open
Eliminate definition: _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING#93743
Labels
P2Important issues not at the top of the work lista: desktopRunning on desktopc: tech-debtTechnical debt, code quality, testing, etc.platform-windowsBuilding on or for Windows specificallyteam-windowsOwned by the Windows platform teamtriaged-windowsTriaged by the Windows platform team
@cbracken

Description

@cbracken
cbracken
opened on Nov 16, 2021

This disables a warning that codecvt_utf8 is deprecated in C++17. This is an issue on Windows. Instead, we should use MultiByteToWideChar() and WideCharToMultiByte(). See notes on this StackOverflow post: How do you properly use WideCharToMultiByte.

We currently define this in:

  • fml/BUILD.gn
  • shell/platform/common/BUILD.gn (fixed)

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: desktopRunning on desktopc: tech-debtTechnical debt, code quality, testing, etc.platform-windowsBuilding on or for Windows specificallyteam-windowsOwned by the Windows platform teamtriaged-windowsTriaged by the Windows platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions