Skip to content

Remove clipBehavior == Clip.none conditions from widgets #98487

New issue
New issue
Closed
#98503
Closed
Remove clipBehavior == Clip.none conditions from widgets#98487
#98503
Assignees
TahaTesser
Labels
c: tech-debtTechnical debt, code quality, testing, etc.f: cupertinoflutter/packages/flutter/cupertino repositoryf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer version
@TahaTesser

Description

@TahaTesser
TahaTesser
opened on Feb 15, 2022

#95593 made Clip.nonea valid clipBehavior

So this means we no longer need to have clipBehavior == Clip.none condition in the code.

Example

flutter/packages/flutter/lib/src/cupertino/form_section.dart

Lines 294 to 303 in d6d3283

Padding(
padding: margin,
child: clipBehavior == Clip.none
? decoratedChildrenGroup
: ClipRRect(
borderRadius: childrenGroupBorderRadius,
clipBehavior: clipBehavior,
child: decoratedChildrenGroup,
),
),

I've found the following widgets use this condition

  • Material
  • CupertinoFormSection
  • InteractiveViewer

Context
#98252
#98483

Metadata

Metadata

Assignees

Labels

c: tech-debtTechnical debt, code quality, testing, etc.f: cupertinoflutter/packages/flutter/cupertino repositoryf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer version

Type

No type

Projects

Nevercode

Status

Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions