Roll Engine from ce9eef7bacf2 to 46c2ccae24e4 (10 revisions)#100244
Conversation
|
Gold has detected about 2 new digest(s) on patchset 10. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@mdebbar Is this also the same issue? |
|
@zanderso no, this one is caused by the browser sometimes producing slightly different screenshot for the same test. We do have a threshold in place to allow some margin or variation, but every once in a while there'll be instances that vary beyond our thresholds. I haven't figured out a solution for this yet. It happens infrequently though. |
|
@mdebbar Thanks. I accepted the diffs. |
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-4403ab1d-ea8c-410a-8053-2cd0d4ecb12a-1647455871
branch
4 participants
flutter/engine@ce9eef7...46c2cca
2022-03-16 [email protected] Roll Skia from e253cc3e55d3 to 9301fe3779bb (1 revision) (flutter/engine#32064)
2022-03-16 [email protected] [web] Position spans absolutely within paragraph (flutter/engine#31907)
2022-03-16 [email protected] Roll Skia from 0d81bc7bb04e to e253cc3e55d3 (1 revision) (flutter/engine#32063)
2022-03-16 [email protected] Roll Fuchsia Mac SDK from jvlI1s78T... to vWlaMIVkM... (flutter/engine#32060)
2022-03-16 [email protected] Roll Skia from 8afe53fd76d3 to 0d81bc7bb04e (2 revisions) (flutter/engine#32057)
2022-03-16 [email protected] Roll Skia from a9bc6c643791 to 8afe53fd76d3 (1 revision) (flutter/engine#32056)
2022-03-16 [email protected] Roll Fuchsia Linux SDK from Ee9OX2o6P... to mVqiTwaVa... (flutter/engine#32055)
2022-03-16 [email protected] [macOS] Forward key events to NSTextInputContext when there's composing text (flutter/engine#32051)
2022-03-16 [email protected] Make tracing safe (flutter/engine#32042)
2022-03-16 [email protected] [windows] Support win_debug_x86 compilation target in engine (flutter/engine#30417)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Ee9OX2o6PFEo to mVqiTwaVayg4
fuchsia/sdk/core/mac-amd64 from jvlI1s78Ta29 to vWlaMIVkMNGE
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md