Skip to content

[flutter_tools] Add --build-number and --build-name support to web and linux#100377

Merged
christopherfujino merged 13 commits intoflutter:masterfrom
JankoLancer:build_numer_name_web_support
Apr 10, 2022
Merged

[flutter_tools] Add --build-number and --build-name support to web and linux#100377
christopherfujino merged 13 commits intoflutter:masterfrom
JankoLancer:build_numer_name_web_support

Conversation

@JankoLancer
Copy link
Contributor

Added support to --build-number and --build-name build options for web and linux. Given values will be written in version.json.

Related Issue

#75909

###Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 18, 2022
@JankoLancer JankoLancer changed the title Add --build-number and --build-name support to web and linux [flutter_tools] Add --build-number and --build-name support to web and linux Mar 18, 2022
@skia-gold
Copy link

Gold has detected about 3 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/100377

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

Merging with failing cirrus customer_testing as LUCI customer_testing is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants