Skip to content

Prepare packages (minus tools,framework) for use_super_parameters#100510

Merged
goderbauer merged 3 commits intoflutter:masterfrom
goderbauer:super_params3
Mar 30, 2022
Merged

Prepare packages (minus tools,framework) for use_super_parameters#100510
goderbauer merged 3 commits intoflutter:masterfrom
goderbauer:super_params3

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 22, 2022 •
edited
Loading

#100575

Once all code in the repo has been migrated, we can turn on the use_super_parameters lint.

@goderbauer goderbauer requested a review from Piinks as a code owner March 22, 2022 01:01
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 22, 2022
@goderbauer goderbauer force-pushed the super_params3 branch 3 times, most recently from 60d6a6b to 7126738 Compare March 28, 2022 16:39
@goderbauer goderbauer mentioned this pull request Mar 28, 2022
Closed
16 tasks
@goderbauer goderbauer force-pushed the super_params3 branch 2 times, most recently from b2f262e to abf884f Compare March 29, 2022 23:48
gspencergoog
gspencergoog approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer merged commit 3e406c6 into flutter:master Mar 30, 2022
@goderbauer goderbauer deleted the super_params3 branch March 30, 2022 22:32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
6ab6a9f 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
77ac42f 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
82d127b 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
f814cb5 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
db7649a 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
8807741 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 2, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
7e19ed4 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 2, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
fcda883 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
cb3345d 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
f3e7fff 
…ameters` (flutter/flutter#100510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
ce4c8df 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
07254c4 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
6dc8d09 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
529b02c 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
97e4f02 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
c2b73c2 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
6ad5ffb 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
a048444 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
e160303 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
87d16c2 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
3b3eb44 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
2758018 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
610edc8 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
cba7c0d 
…ameters` (flutter/flutter#100510)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
3e406c6 Prepare packages (minus tools,framework) for `use_super_par…
aeb0a98 
…ameters` (flutter/flutter#100510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @gspencergoog