Skip to content

Add back Gold passfail#100576

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
Piinks:goldFinalize
Mar 22, 2022
Merged

Add back Gold passfail#100576
fluttergithubbot merged 1 commit intoflutter:masterfrom
Piinks:goldFinalize

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 22, 2022

Part of #100304

This adds back the passfail flag, but it does not re-enable the exception that would be thrown in post submit if the call returns an error. Will continue to monitor before fully restoring.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 22, 2022
@Piinks Piinks added the c: tech-debt Technical debt, code quality, testing, etc. label Mar 22, 2022
@Piinks Piinks requested a review from goderbauer March 22, 2022 19:01
goderbauer
goderbauer approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 8e7b361 into flutter:master Mar 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2022
@engine-flutter-autoroll
8e7b361 Add back Gold passfail (flutter/flutter#100576)
1c2498e
@Piinks Piinks mentioned this pull request Mar 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
8e7b361 Add back Gold passfail (flutter/flutter#100576)
370494c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
8e7b361 Add back Gold passfail (flutter/flutter#100576)
1a107cc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
8e7b361 Add back Gold passfail (flutter/flutter#100576)
c0ca6ba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
8e7b361 Add back Gold passfail (flutter/flutter#100576)
e5212fd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
8e7b361 Add back Gold passfail (flutter/flutter#100576)
4e7f6c7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
8e7b361 Add back Gold passfail (flutter/flutter#100576)
61fbf00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
8e7b361 Add back Gold passfail (flutter/flutter#100576)
111cc16
@matanlurey matanlurey mentioned this pull request Feb 21, 2024
Merged
auto-submit bot pushed a commit to flutter/engine that referenced this pull request Feb 21, 2024
@matanlurey
Fail engine post-submit on skia-gold comparions. (#50826)
bd60b55 
Similar to the framework in flutter/flutter#100576.

Closes flutter/flutter#143617.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @goderbauer @fluttergithubbot