Editable text sends enableInteractiveSelection to text input client#100649
Editable text sends enableInteractiveSelection to text input client#100649chunhtai merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: text input
| this.autofillConfiguration = AutofillConfiguration.disabled, | ||
| this.enableIMEPersonalizedLearning = true, | ||
| this.enableDeltaModel = false, | ||
| }) : assert(inputType != null), |
There was a problem hiding this comment.
these are all non-null type, these checks are redundant
There was a problem hiding this comment.
Good point, I thought that the compiler wouldn't let you do this, but I guess it will. I'll keep an eye out for other places that can be cleaned up like this.
There was a problem hiding this comment.
It looks like it will still be useful for user that has not migrate to null safety, so I will revert this change
There was a problem hiding this comment.
Ah that's right. Sounds good.
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Just some docs nits below.
| this.autofillConfiguration = AutofillConfiguration.disabled, | ||
| this.enableIMEPersonalizedLearning = true, | ||
| this.enableDeltaModel = false, | ||
| }) : assert(inputType != null), |
There was a problem hiding this comment.
Good point, I thought that the compiler wouldn't let you do this, but I guess it will. I'll keep an eye out for other places that can be cleaned up like this.
| /// {@endtemplate} | ||
| final bool enableSuggestions; | ||
|
|
||
| /// Whether to a user can change its selection. |
There was a problem hiding this comment.
Nit: "Whether a user can change the selection."
| /// Whether to a user can change its selection. | ||
| /// | ||
| /// This flag only affects iOS VoiceOver. On Android Talkback, the selection | ||
| /// change is sent through semantics actions and are directly disabled from |
There was a problem hiding this comment.
What is "directly disabled" here, the selection change? If so then "are" should be "is".
2 participants
pipes enableInteractiveSelection to the engine side
engine part flutter/engine#32223
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.