Skip to content

Fix crashes when current route parsing transactions are discarded#100657

Merged
chunhtai merged 3 commits intoflutter:masterfrom
chunhtai:issues/100225
Apr 4, 2022
Merged

Fix crashes when current route parsing transactions are discarded#100657
chunhtai merged 3 commits intoflutter:masterfrom
chunhtai:issues/100225

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Mar 23, 2022

There doesn't seem to be a way to create generic future that can be downward cast to any type. This pr refactor the logic around discarding parsing transaction

fixes #100225

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels Mar 23, 2022
@chunhtai chunhtai requested a review from goderbauer March 23, 2022 23:00
chunhtai
chunhtai commented Mar 23, 2022
View reviewed changes
@chunhtai
Copy link
Contributor Author

chunhtai commented Apr 4, 2022

@goderbauer Thanks for review, this is ready for another look

goderbauer
goderbauer approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai merged commit 26398e6 into flutter:master Apr 4, 2022
This was referenced Apr 4, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
38361da 
…rded (flutter/flutter#100657)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
d5ef9e6 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
7dbe1e6 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
b9daa7b 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
213b5fb 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
034dbb8 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
7dd4193 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
3cbe7d2 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
06134f9 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
a9901e4 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
cdb839f 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
e335588 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
fdba25e 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
c68ea9c 
…rded (flutter/flutter#100657)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
26398e6 Fix crashes when current route parsing transactions are disca…
f1f8f91 
…rded (flutter/flutter#100657)
@victorsanni victorsanni mentioned this pull request Feb 13, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_CastError in _RouterState._verifyRouteInformationParserStillCurrent.<fn> at line 666

2 participants

@chunhtai @goderbauer