Skip to content

✨ Android Q transition by default#100812

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
AlexV525:zoom-page-transition-by-default
Mar 26, 2022
Merged

✨ Android Q transition by default#100812
fluttergithubbot merged 1 commit intoflutter:masterfrom
AlexV525:zoom-page-transition-by-default

Conversation

@AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Mar 26, 2022

Continue from #98559, fix #43277.

Breaking change note: flutter/website#6646.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@AlexV525 AlexV525 requested review from Hixie, dnfield and zanderso March 26, 2022 01:47
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 26, 2022
@AlexV525
Copy link
Member Author

AlexV525 commented Mar 26, 2022

This adds an extra fix to the overall experience test to resolve the revert. FYI @zanderso

@AlexV525
Copy link
Member Author

AlexV525 commented Mar 26, 2022

I'm currently available and will keep an eye on further changes if any of them are requested.

zanderso
zanderso requested changes Mar 26, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any update on the performance issues mentioned in #43277 and/or #88492?

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 26, 2022

This pull request is not suitable for automatic merging in its current state.

  • This pull request has changes requested by @zanderso. Please resolve those before re-applying the label.

@AlexV525
Copy link
Member Author

AlexV525 commented Mar 26, 2022

Is there any update on the performance issues mentioned in #43277 and/or #88492?

This should be addressed by flutter/engine#29775 as @flar said in #43277 (comment).

@AlexV525 AlexV525 mentioned this pull request Mar 26, 2022
Merged
3 tasks
zanderso
zanderso approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it thanks.

@AlexV525
Copy link
Member Author

AlexV525 commented Mar 26, 2022

Is there any update on the performance issues mentioned in #43277 and/or #88492?

We still need to monitor if any metrics have a sharp increase after this. Thanks for keeping track.

@zanderso
Copy link
Member

zanderso commented Mar 26, 2022

Is there any update on the performance issues mentioned in #43277 and/or #88492?

We still need to monitor if any metrics have a sharp increase after this. Thanks for keeping track.

@GaryQian is the current sheriff. Gary, please watch out for the perf impact of this change in SkiaPerf.

@fluttergithubbot fluttergithubbot merged commit 543a7e8 into flutter:master Mar 26, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2022
@engine-flutter-autoroll
543a7e8 ✨ Android Q transition by default (flutter/flutter#100812)
bd12cd5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
543a7e8 ✨ Android Q transition by default (flutter/flutter#100812)
a8f70c6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
543a7e8 ✨ Android Q transition by default (flutter/flutter#100812)
5203c87
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
543a7e8 ✨ Android Q transition by default (flutter/flutter#100812)
fd59952
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
543a7e8 ✨ Android Q transition by default (flutter/flutter#100812)
1588eb8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
543a7e8 ✨ Android Q transition by default (flutter/flutter#100812)
1fb0469
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
543a7e8 ✨ Android Q transition by default (flutter/flutter#100812)
910b560
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
543a7e8 ✨ Android Q transition by default (flutter/flutter#100812)
ed62e3d
@zanderso
Copy link
Member

zanderso commented Mar 29, 2022

This has change has caused a larger memory footprint: https://flutter-flutter-perf.skia.org/e/?begin=1647895223&end=1648529864&keys=X845c9ddf84d6ac62deff51c6cee6ad22&requestType=0&xbaroffset=28090

Is that intentional?

@AlexV525
Copy link
Member Author

AlexV525 commented Mar 29, 2022

Is that intentional?

@zanderso I would say it's intentional since it involves more transforms than before. But I can't tell whether the difference should be acceptable.

@AlexV525 AlexV525 deleted the zoom-page-transition-by-default branch April 7, 2022 02:11
@AlexV525 AlexV525 mentioned this pull request Apr 7, 2022
Closed
@flar flar mentioned this pull request Apr 15, 2022
Closed
@bleroux bleroux mentioned this pull request Mar 1, 2023
Closed
@bleroux bleroux mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@Hixie Hixie Awaiting requested review from Hixie

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Android 10 Activity Animation the default animation

4 participants

@AlexV525 @fluttergithubbot @zanderso @dnfield