Prepare framework for use_super_parameters#100905
Merged
goderbauer merged 1 commit intoflutter:masterfrom Apr 14, 2022
Merged
Conversation
flutter-dashboard
bot
added
a: accessibility
16 tasks
goderbauer
force-pushed
the
super_framework
branch
3 times, most recently
from
eefffac to
8917337
Compare
goderbauer
commented
Mar 29, 2022
goderbauer
changed the title
use_super_parametersuse_super_parameters
goderbauer
force-pushed
the
super_framework
branch
7 times, most recently
from
8378ec1 to
db89a01
Compare
This was referenced Apr 1, 2022
goderbauer
force-pushed
the
super_framework
branch
from
db89a01 to
59513db
Compare
gspencergoog
approved these changes
Apr 2, 2022
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
RSLGTM: GitHub can't handle this many files in a review, but I assume that they're all basically the same.
goderbauer
force-pushed
the
super_framework
branch
from
59513db to
e63bb78
Compare
goderbauer
force-pushed
the
super_framework
branch
6 times, most recently
from
24e09e1 to
a9f2e96
Compare
goderbauer
changed the title
use_super_parametersuse_super_parameters
goderbauer
force-pushed
the
super_framework
branch
from
a9f2e96 to
62ba05d
Compare
goderbauer
changed the title
use_super_parametersuse_super_parameters
goderbauer
force-pushed
the
super_framework
branch
7 times, most recently
from
695df00 to
e426294
Compare
goderbauer
force-pushed
the
super_framework
branch
from
e426294 to
d7fad68
Compare
goderbauer
changed the title
use_super_parametersuse_super_parameters
Member
Author
|
"Google testing" has some kind of infra problem and it's not able to run the tests. I am going to merge this and watch for post-submit failures. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLOCKED on dart-lang/sdk#48769.Fixed.BLOCKED ON dart-lang/sdk#48727.Fixed.BLOCKED ON dart-lang/sdk#48719.Fixed.BLOCKED ON dart-lang/sdk#48697.Fixed.#100575
Once all code in the repo has been migrated, we can turn on the use_super_parameters lint.