[flutter_tools] fix flutter create --offline#100941
Merged
christopherfujino merged 14 commits intoflutter:masterfrom Apr 8, 2022
Merged
[flutter_tools] fix flutter create --offline#100941christopherfujino merged 14 commits intoflutter:masterfrom
christopherfujino merged 14 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
Jasguerrero
changed the title
| @@ -171,7 +171,14 @@ class PrecacheCommand extends FlutterCommand { | |||
| } | |||
| } | |||
| if (!await _cache.isUpToDate()) { | |||
Contributor
There was a problem hiding this comment.
I don't think flutter precache --offline doesn't really make sense, as the point is to download pre-built binaries.
Contributor
|
For testing, I would recommend adding a new test to test/commands.shard/hermetic/create_usage_test.dart and use the FakeProcessManager and FakeCommand like: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/commands.shard/hermetic/build_ios_test.dart#L122 |
|
|
||
| /// Update the cache to contain all `requiredArtifacts`. | ||
| Future<void> updateAll(Set<DevelopmentArtifact> requiredArtifacts) async { | ||
| Future<void> updateAll(Set<DevelopmentArtifact> requiredArtifacts, [bool offline = false]) async { |
Contributor
There was a problem hiding this comment.
for these optional parameters can you use named parameters instead?
|
|
||
| /// Update the cache to contain all `requiredArtifacts`. | ||
| Future<void> updateAll(Set<DevelopmentArtifact> requiredArtifacts) async { | ||
| Future<void> updateAll(Set<DevelopmentArtifact> requiredArtifacts, [bool offline = false]) async { |
Contributor
There was a problem hiding this comment.
Suggested change
| Future<void> updateAll(Set<DevelopmentArtifact> requiredArtifacts, [bool offline = false]) async { | |
| Future<void> updateAll(Set<DevelopmentArtifact> requiredArtifacts, {bool offline = false}) async { |
christopherfujino
force-pushed
the
create_when_offline
branch
from
1aca664 to
04bcbb1
Compare
…flutter into create_when_offline # Conflicts: # packages/flutter_tools/test/commands.shard/hermetic/create_usage_test.dart
| // ios-deploy on macOS) are required to determine `requiredArtifacts`. | ||
| await globals.cache.updateAll(<DevelopmentArtifact>{DevelopmentArtifact.universal}); | ||
| await globals.cache.updateAll(await requiredArtifacts); | ||
| bool offline; |
Contributor
There was a problem hiding this comment.
Suggested change
| bool offline; | |
| final bool offline = argParser.options.containsKey('offline') ? boolArg('offline') : false; |
| fs.directory(directory).childFile('.packages').createSync(); | ||
| if (offline == true){ | ||
| calledGetOffline += 1; | ||
| } |
Contributor
There was a problem hiding this comment.
style nit. else should be on this line, after }
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 8, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #96286
Pre-launch Checklist
///).