Skip to content

Remove the run_loop.h and run_loop.cpp files from template_manifest.json#100976

Merged
fluttergithubbot merged 9 commits intoflutter:masterfrom
linxuebin1990:master
Apr 12, 2022
Merged

Remove the run_loop.h and run_loop.cpp files from template_manifest.json#100976
fluttergithubbot merged 9 commits intoflutter:masterfrom
linxuebin1990:master

Conversation

@linxuebin1990
Copy link
Member

As known from #79969, the run_loop.h and run_loop.cpp files have been removed.
So we need to remove the run_loop.h and run_loop.cpp files from template_manifest.json.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

linxuebin1990 and others added 2 commits March 30, 2022 00:04
run_loop.h and  run_loop.cpp has already removed, so remove remove run_loop from template_manifest.json
remove run_loop from template_manifest.json
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 29, 2022
@linxuebin1990
Copy link
Member Author

cc @knopp @filiph

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants