Add variable font axes to TextStyle#100978
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Apr 12, 2022
Merged
Conversation
flutter-dashboard
bot
added
a: text input
dnfield
reviewed
Mar 29, 2022
Contributor
There was a problem hiding this comment.
Please include a doc comment example that shows using this API for some commonly available font.
dnfield
approved these changes
Mar 29, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
The code LGTM.
If we want to land this to make branch cut I think it's probably fine, we could follow up on docs/examples in a separate PR. But adding an example would really help here and shouldn't be too complicated.
jason-simmons
force-pushed
the
variable_fonts
branch
2 times, most recently
from
fbbc2b6 to
ba56034
Compare
jason-simmons
force-pushed
the
variable_fonts
branch
from
ba56034 to
0e3958b
Compare
jason-simmons
force-pushed
the
variable_fonts
branch
from
0e3958b to
5ad8067
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 12, 2022
This was referenced Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #87291