Skip to content

Reland: "Use texture layer when displaying an Android view"#100990

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
blasten:reland_pv_tx2
Mar 30, 2022
Merged

Reland: "Use texture layer when displaying an Android view"#100990
fluttergithubbot merged 4 commits intoflutter:masterfrom
blasten:reland_pv_tx2

Conversation

@blasten
Copy link

@blasten blasten commented Mar 29, 2022

Relands #100237

I wasn't able to reproduce (on neither emulator/physical device) the test failure that reverted this PR.
My only guess is that the button I added to the app under test pushed some other keyed buttons offscreen.

I'm adding bringup: true to the test.

Change summary

There's a customer in g3 that uses WebRTC view. This view is a SurfaceView, and cannot use a texture layer.

Commit 2e915be adds a new factory PlatformViewsService.initExpensiveAndroidView that can be used to allow SurfaceViews in a Flutter app.

@blasten blasten requested a review from keyonghan as a code owner March 29, 2022 19:19
@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 29, 2022
@blasten blasten requested review from GaryQian and zanderso March 29, 2022 19:19
@zanderso
Copy link
Member

zanderso commented Mar 29, 2022

So this change is landing a new feature, modifying a test for that feature, and making that test non-blocking? Is the idea that that test would then be immediately worked on next to sort out the problem with it that this change introduces? If so, we should definitely have a high-priority issue for that, so that this PR can be backed out unless that problem can be sorted out relatively quickly because we have a branch cut coming up.

@blasten blasten mentioned this pull request Mar 29, 2022
Closed
@blasten
Copy link
Author

blasten commented Mar 29, 2022

@zanderso done in 6aeea66.

This issue is not super high priority issue. I suspect the issue is that the resolution of the device is making some UI elements go offscreen, and failing the test in that scenario. I re-adjusted the layout to validate that theory.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 29, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@blasten
Copy link
Author

blasten commented Mar 30, 2022

@jmagman, @CaseyHillers do you know if there's an issue with the mac pool? these tasks have been queued for >3h.

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Mar 30, 2022

@jmagman, @CaseyHillers do you know if there's an issue with the mac pool? these tasks have been queued for >3h.

There was quite a few PRs today, so capacity was limited (g/flutter-infra-alerts shows a few of these). The checks have run and passed

@blasten
Copy link
Author

blasten commented Mar 30, 2022

got it. Thanks!

@fluttergithubbot fluttergithubbot merged commit 032205e into flutter:master Mar 30, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 30, 2022
@engine-flutter-autoroll
032205e Reland: "Use texture layer when displaying an Android view" (f…
34796ef 
…lutter/flutter#100990)
@zanderso
Copy link
Member

zanderso commented Mar 31, 2022

SkiaPerf results https://flutter-flutter-perf.skia.org/e/?begin=1648567675&end=1648652113&keys=X2e15204070da09abe78c98871d04b687&num_commits=50&request_type=1&xbaroffset=28128

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
032205e Reland: "Use texture layer when displaying an Android view" (f…
c8e2075 
…lutter/flutter#100990)
@akbiggs akbiggs mentioned this pull request Apr 6, 2022
Closed
@Piinks Piinks mentioned this pull request Jun 16, 2022
Closed
@0xZOne 0xZOne mentioned this pull request Jan 28, 2024
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Jan 30, 2024
@0xZOne
Using initExpensiveAndroidView for Android Hybrid Composition Mode (#…
ccb2b44 
…142399)

After #100990, we should use `initExpensiveAndroidView` for Android Hybrid Composition mode instead of `initSurfaceAndroidView`. 

`initSurfaceAndroidView` attempts to use `TLHC` when possible. In cases where that is not supported, it falls back to using Hybrid Composition.

flutter/engine#49414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

+1 more reviewer

@GaryQian GaryQian GaryQian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blasten @zanderso @fluttergithubbot @CaseyHillers @GaryQian