Skip to content

Reland "Enable caching of CPU samples collected at application startup (#89600)"#100995

Merged
fluttergithubbot merged 12 commits intomasterfrom
reland_streaming
Mar 30, 2022
Merged

Reland "Enable caching of CPU samples collected at application startup (#89600)"#100995
fluttergithubbot merged 12 commits intomasterfrom
reland_streaming

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Mar 29, 2022

Feature is now placed behind --cache-startup-samples flag.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 29, 2022
@christopherfujino
Copy link
Contributor

christopherfujino commented Mar 30, 2022

Original PR: #89600
Revert PR: #89704

christopherfujino
christopherfujino reviewed Mar 30, 2022
View reviewed changes
@bkonyi bkonyi force-pushed the reland_streaming branch from 468bcc8 to 3871012 Compare March 30, 2022 18:30
christopherfujino
christopherfujino approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 75baed5 into master Mar 30, 2022
@fluttergithubbot fluttergithubbot deleted the reland_streaming branch March 30, 2022 20:50
@bkonyi bkonyi mentioned this pull request Mar 30, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
88ccc6b 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
c16eef8 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
dd4f9a4 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
ae9889c 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
fd38073 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
faa7dcd 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
ce2790b 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 2, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
e4101d1 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 2, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
4a2b5fe 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
b1d02cb 
…n startup (#89600)" (flutter/flutter#100995)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
152a528 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
28fce38 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
0c3f818 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
c4dfdc2 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
0a3fdef 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
fc0fc44 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
9236865 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
cd3d013 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
2b329de 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
1b0d07e 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
3cf1aad 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
6f61c98 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
fcc40cc 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
5ec8ad1 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
479a175 
…n startup (#89600)" (flutter/flutter#100995)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
75baed5 Reland "Enable caching of CPU samples collected at applicatio…
f26b1db 
…n startup (#89600)" (flutter/flutter#100995)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkonyi @christopherfujino @kenzieschmoll @fluttergithubbot