Enable track widget creation when generating Generated.xcconfig#101123
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Apr 11, 2022
yeatse:track-widget-creation
Merged
Enable track widget creation when generating Generated.xcconfig#101123fluttergithubbot merged 4 commits intoflutter:masterfrom yeatse:track-widget-creation
fluttergithubbot merged 4 commits intoflutter:masterfrom
yeatse:track-widget-creation
Conversation
flutter-dashboard
bot
added
the
tool
Contributor
|
@jmagman can you take a look at this one? |
jmagman
reviewed
Apr 7, 2022
jmagman
requested changes
Apr 8, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Requesting changes to make this the default BuildInfo.debug behavior.
Contributor
Author
|
@jmagman Thanks for your review! Just updated |
jmagman
reviewed
Apr 8, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM with minor null nit.
Thanks for the contribution!
packages/flutter_tools/test/general.shard/resident_runner_test.dart
Outdated
Show resolved
Hide resolved
….dart Co-authored-by: Jenn Magder <[email protected]>
jmagman
added
waiting for tree to go green
platform-ios
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
|
Adding @christopherfujino for second review, forgot we needed that. |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This was referenced Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
This was referenced Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing a flutter module project, flutter will generate a
Generated.xcconfigfor iOS, settingTRACK_WIDGET_CREATION=false. This file is used to generateflutter_export_environment.sh, and finally loaded bypodhelper.rbto build into the host app. However when we runflutter attachto it,track-widget-creationdefaults to true so hot reload breaks until we hot restart it.This fix set
TRACK_WIDGET_CREATION=trueinGenerated.xcconfig, making hot reload in add-to-app work as expected.Fixes #94681
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.