Remove trailing spaces in repo#101191
Remove trailing spaces in repo#101191guidezpl merged 5 commits intoflutter:masterfrom guidezpl:remove-trailing-spaces
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
goderbauer
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the clean-up!
|
I thought we have a check for this, though, that stops code with trailing spaces from getting submitted? |
|
Oh, does that check maybe only trigger on changed lines and not existing violations? |
|
Or maybe it only checks .dart files? Let's fix the test, then we don't need a test exemption here. :-) |
|
It does check all files, but only modified lines. My guess is the cases this PR fixes predate the test. So fine to submit without modifying a test? |
Spring cleaning